Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Customize the title in batch action. #6909

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lanzhiheng
Copy link
Contributor

Sometime i would like to custom the title of batch_action.

@lanzhiheng lanzhiheng force-pushed the custom-the-title-of-batch-title branch from 7022e1f to c2f2b53 Compare April 15, 2021 13:25
@deivid-rodriguez
Copy link
Member

I don't have a strong opinion but I guess it's fine. @javierjulio?

@javierjulio
Copy link
Member

@deivid-rodriguez I don't see why the i18n option wouldn't suffice for this as I think that would be better but then I tried thinking of what would be similar to this elsewhere in AA and that would probably be filters as a label can be given to override the i18n default. So I think this would be ok. The one thing I'd bring up is considering using label: instead of title: for the option name as we use the former mostly and with menu-like components.

@deivid-rodriguez
Copy link
Member

Yeah, I had the same initial thought ("just use i18n"), but then I thought having to use i18n on monolingual apps to configure these simple things is a bit annoying an somewhat a "feature abuse" so this thing seems simple and could come handy sometimes. Agreed on using label to name things consistently 👍.

@deivid-rodriguez
Copy link
Member

Although forms seems to already have a title option that behaves the same way, so we're already inconsistent, so I guess we should choose the name that makes most sense for batch actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants