Unify specifying label in show -> attributes_table

[mirelon]

Up to now, the only way to specify a label in a row in attributes_table was by using the first argument. The data was then taken from executing a block:

attributes_table do
  row 'Renamed' do |r|
    r.username
  end
end

This pull request allows for syntax:

attributes_table do
  row 'Renamed', :username
end

The same syntax is used by index:

index do
    column 'Renamed', :username
end

Closes #3359, closes #167

[mingchang]

So this has been sitting around for a year due to an extra space in the pull request?

lib/active_admin/views/components/attributes_table.rb:25:13: C: Layout/ExtraSpacing: Unnecessary spacing detected.
        data  = args[1] || args[0]
            ^

355 files inspected, 1 offense detected

Is there any way to remove the space and submit this again? I'm not the pull request creator so I'm not sure how this can progress to the next step.

[deivid-rodriguez]

The reason is not the space, but that nobody has been able to review it yet. I'll try to find some time.

[mingchang]

Cool, got it. I think this is a great addition to ActiveAdmin due to much cleaner code in customizing "show" pages. Would clear up some confusion I've seen around the net as well from devs who found this new syntax much more intuitive. Thanks for the quick response!

[javierjulio]

@mirelon I will accept this if a test is added. Thank you.