This repository has been archived by the owner on Mar 4, 2021. It is now read-only.
new optional input: asset_label #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricKotato
reviewed
Mar 31, 2020
| @@ -26,6 +27,7 @@ async function run() { | |||
| url: uploadUrl, | |||
| headers, | |||
| name: assetName, | |||
| label: assetLabel, | |||
There was a problem hiding this comment.
Will action work fine if you won't set asset_label?
There was a problem hiding this comment.
yes. It may be good to add a github action to test this against the real github API, to avoid this kind of uncertainty.
lovasoa
changed the title
|
Can someone with commit access please review this PR ? @IAmHughes maybe ? |
|
@IAmHughes Any chance this could be merged? This feature would be really handy to have. |
erthink
approved these changes
May 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18