Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cosign to v2.2.3 in docker-publish.yml #2358

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update cosign to v2.2.3 in docker-publish.yml #2358

wants to merge 3 commits into from
+1 −3

Conversation

TK221
Copy link

@TK221 TK221 commented Mar 26, 2024

Updating cosign-installer to v3.4.0 and cosign to v.2.2.3, resulting in no more signing errors.
https://blog.sigstore.dev/tuf-root-update/

@TK221 TK221 requested a review from a team as a code owner March 26, 2024 20:57
@kj800x kj800x mentioned this pull request Apr 2, 2024
Open
kj800x
kj800x reviewed Apr 2, 2024
View reviewed changes
Copy link

@kj800x kj800x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixed my build. Thank you

@TK221 TK221 requested a review from a team as a code owner April 3, 2024 12:53
lupusbytes added a commit to lupusbytes/vpn-rtorrent-flood that referenced this pull request Apr 6, 2024
@lupusbytes
ci: update cosign actions/starter-workflows#2358
bca0ced
lupusbytes added a commit to lupusbytes/vpn-rtorrent-flood that referenced this pull request Apr 6, 2024
@lupusbytes
ci: update cosign actions/starter-workflows#2358
20f95cc
lupusbytes added a commit to lupusbytes/vpn-rtorrent-flood that referenced this pull request Apr 8, 2024
@lupusbytes
ci: update cosign actions/starter-workflows#2358
544ac63
benmayne added a commit to benmayne/backup that referenced this pull request Apr 13, 2024
@benmayne
Update docker-publish.yml
08ab9df 
actions/starter-workflows#2358
@invince
Copy link

invince commented May 5, 2024

Fix works, great job

curlew
curlew approved these changes May 8, 2024
View reviewed changes
Copy link

@curlew curlew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me, thanks

@kj800x
Copy link

kj800x commented May 8, 2024

Hi @yoannchaudet @JamesMGreene @alexisabril, sorry to cold tag like this, but what is the process for getting a PR like this reviewed and merged?

Newly generated docker publish workflows fail because they need this fix. It would be valuable to get this merged.

Eason-S-Lu
Eason-S-Lu suggested changes May 11, 2024
View reviewed changes
Copy link

@Eason-S-Lu Eason-S-Lu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request an update to 3.5.0 and drop the "with" section.

Eason-S-Lu
Eason-S-Lu approved these changes May 15, 2024
View reviewed changes
Copy link

@Eason-S-Lu Eason-S-Lu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, I hope they merge this PR.
Eason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kj800x kj800x kj800x left review comments

@curlew curlew curlew approved these changes

@Eason-S-Lu Eason-S-Lu Eason-S-Lu approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TK221 @invince @kj800x @curlew @Eason-S-Lu