New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging #1074

Open

jsoref wants to merge 3 commits into actions:main from jsoref:fix-logging

Commits on Aug 11, 2023

Fix logging for items transitioning to stale

The issue that the stale action finds in this log excerpt *is* stale,
it just isn't marked that way yet. Saying that the issue isn't stale
is misleading and contradictory.

https://github.com/jsoref/stale-bot-debug/actions/runs/5828506506/job/15806335430#step:2:97

::group::[actions#2] Issue actions#2
[actions#2] Issue actions#2
  [actions#2] Found this issue last updated at: 2023-08-09T14:33:12Z
...
  [actions#2] This issue is not stale
...
  [actions#2] This issue should be stale based on the last update date the 09-08-2023 (2023-08-09T14:33:12Z)
  [actions#2] This issue should be marked as stale based on the option days-before-issue-stale (https://github.com/actions/stale#days-before-issue-stale) (1)
  [actions#2] Marking this issue as stale

jsoref committed Aug 11, 2023

Fix logging for removing nonexistent label

https://github.com/jsoref/stale-bot-debug/actions/runs/5828506506/job/15806335430#step:2:97

::group::[actions#2] Issue actions#2
[actions#2] Issue actions#2
...
  [actions#2] Removing all the labels specified via the labels-to-remove-when-stale (https://github.com/actions/stale#labels-to-remove-when-stale) option.
  [actions#2] Removing the label "label-to-add-when-unstale" from this issue...
  Error: [actions#2] Error when removing the label: "Label does not exist"

The quotes on this last line make it look like the action was trying to
remove a label named `Label does not exist`.

This change removes the quotes to make it clear that the text is just an
error message (which is implied by the `:`) as opposed to the name of a
label, which is the reading one gets from the inclusion of additional
quotes around the text.

jsoref committed Aug 11, 2023

Fix logging because not all items are issues

https://github.com/jsoref/stale-bot-debug/actions/runs/5828506506/job/15806335430#step:2:56

Processing the batch of issues  actions#1  containing  3  issues...
::group::[actions#3] Pull request actions#3
[actions#3] Pull request actions#3
...
::group::[actions#2] Issue actions#2
[actions#2] Issue actions#2
...
::group::[actions#1] Issue actions#1
[actions#1] Issue actions#1
...
Batch  actions#1  processed.
No more issues found to process. Exiting...
Statistics:
Processed items: 3
├── Processed issues: 2
└── Processed PRs   : 1

Clearly this action sometimes understands that users do not view all
items as issues.

This change applies the `items` nomenclature to this initial logging.

jsoref committed Aug 11, 2023