Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not close pinned issues #1049

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Do not close pinned issues #1049

wants to merge 4 commits into from
+245 −74

Conversation

dsame
Copy link
Contributor

@dsame dsame commented Jul 6, 2023 •
edited

Description:
Do not close pinned issues

  • Added "exempt-pinned-issues" input
  • Added memoized function private async getIssueEvents(issue: Issue) to src/classes/issues-processor.ts
  • Added function getPinnedStatus and refactored getLabelCreationDate, both use getIssueEvents
  • Added if (await this._isSkipPinned(issue)) {... return ...} to src/classes/issues-processor.ts

Related issue:
A link to the related issue.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@dsame dsame marked this pull request as ready for review July 7, 2023 11:09
@dsame dsame requested a review from a team as a code owner July 7, 2023 11:09
@dsame dsame linked an issue Jul 12, 2023 that may be closed by this pull request
Do not close pinned issues #990
Open
@IvanZosimov IvanZosimov self-requested a review July 17, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marko-zivic-93 marko-zivic-93 marko-zivic-93 approved these changes

@nikolai-laevskii nikolai-laevskii nikolai-laevskii approved these changes

@IvanZosimov IvanZosimov Awaiting requested review from IvanZosimov

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not close pinned issues
3 participants
@dsame @marko-zivic-93 @nikolai-laevskii