Allow multiple rs with same name in a namespace #3476
+13
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Support fullnameOverride option 2. If release name contains chart name it will be used as a full name. 3. Use "<release-name>-<chart-name>" as fullname
Use fullname as resource name and selector instead of scale-set-name
chandranathmondal
requested review from
mumoshu,
toast-gear,
nikola-jokic,
rentziass and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following changes are made:
1. Update chart fullname
i. Support fullnameOverride option
ii. If release name contains chart name it will be used as a full name.
iii. Use
<release-name>-<chart-name>as fullname2. Use chart fullname as resource name and selector instead of scale-set-name
These changes assign a unique noPermissionServiceAccountName and AutoscalingRunnerSet name based on the release name so that two different scale-sets can be present in the same namespace when they are part of two different releases within the namespace.