-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boost Comments and Like Notifications #2468
base: main
Are you sure you want to change the base?
Conversation
Hey there 👋,
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2468 +/- ##
==========================================
+ Coverage 27.76% 28.25% +0.48%
==========================================
Files 660 680 +20
Lines 44697 45684 +987
==========================================
+ Hits 12410 12906 +496
- Misses 32287 32778 +491
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
185f2dd
to
80a90ef
Compare
This PR brings support for space-object push notification subscriptions and implements the entire flow for comments and likes on boosts.
High-level Product outline
Updates, Attachments and Comments on any space object (Pin, Boost, etc) can create push notifications. The user can subscribe to updates of any object, but may also to be autosubscribed upon creating or interacting with an object. They can of course disable that feature as well as unsubscribe to any previously subscribed object to not receive any further notifications of it.
This PR
This PR implements that feature in the rust infrastructure by providing the specific push-rule on any parent-object-related events or sub-types of that parent (think only comments of a boost). Additionally, it implements the feature for boost (where we don't have updates) comments and likes. It implements the auto-subscribe for boosts, as well as UI for managing object subscriptions, put behind a default-off feature-flag. Further more it implements the notification parsing for these new reaction and comments, which come with tests and has a run-by-fix for boost-push-notifications (which failed to parse). It also adds tests for notifify and activates them in the CI-runner to ensure that we interpret these notifications correctly.
Demo
Autosubscribe to boosts
screen-20250107-105311.mp4
Receiving Comment and Like
screen-20250107-105436.mp4
Boost Notifications
fix, with image
screen-20250107-110636.mp4
open Todo's: