New Room Preview facilities

.changes/2373-room-previews.md

@@ -0,0 +1,5 @@
+- Will we now show you a preview of the space when you try to access an object you don't have access to you yet with the ability to let you quickly join the space and interact with the object
+- We are now showing a Room Preview with additional information when you click on the title in an invite
+- the QR Code for objects now shows you the details that will be shared with the reader
+- A fix has been made when joining required to go through more than one server
+- We are now sharing our own target server in the via-parameter of shared links

app/android/settings.gradle

@@ -18,7 +18,7 @@ pluginManagement {
 
 plugins {
     id "dev.flutter.flutter-plugin-loader" version "1.0.0"
-    id "com.android.application" version '8.7.1' apply false
+    id "com.android.application" version '8.7.3' apply false
     id "org.jetbrains.kotlin.android" version "1.9.10" apply false
     id "com.google.gms.google-services" version "4.4.2" apply false
 }

app/lib/common/extensions/record_helpers.dart

@@ -0,0 +1,29 @@
+/// AllHashed is a helper for record-types to ensure they are cached
+/// properly by riverpod.
+///
+/// When giving a record e.g. `typedef query = ({String roomIdOrAlias, List<String> serverNames});`
+/// as the parameter to a riverpod provider, the latter `List<String>` will
+/// have different hashes for every instance created. This means that even if
+/// both are `List.empty()` riverpod doesn't recognise them as the same and will
+/// run the provider again, cluttering up memory as well as unnecessary computation
+///
+/// This type, given a list of items `T` will always return the same hash for the
+/// same items.
+class AllHashed<T> {
+  final List<T> items;
+
+  AllHashed(this.items);
+
+  @override
+  int get hashCode => Object.hashAll(items);
+
+  @override
+  bool operator ==(Object other) {
+    if (other is AllHashed<T>) {
+      return items == other.items;
+    } else if (other is List<T>) {
+      return items == other;
+    }
+    return false;
+  }
+}

app/lib/common/toolkit/errors/error_dialog.dart

@@ -18,7 +18,7 @@ class ActerErrorDialog extends StatelessWidget {
 
   final String? title;
   final String? text;
-  final String Function(Object error)? textBuilder;
+  final ErrorTextBuilder? textBuilder;
   final bool includeBugReportButton;
 
   /// Dialog Border Radius
@@ -48,7 +48,7 @@ class ActerErrorDialog extends StatelessWidget {
     /// Text of the dialog
     String? text,
     VoidCallback? onRetryTap,
-    String Function(Object error)? textBuilder,
+    ErrorTextBuilder? textBuilder,
     bool includeBugReportButton = true,
 
     /// Dialog Border Radius
@@ -88,18 +88,23 @@ class ActerErrorDialog extends StatelessWidget {
       title: title ??
           switch (err) {
             ErrorCode.notFound => lang.notFound,
+            ErrorCode.forbidden => lang.forbidden,
             _ => lang.fatalError,
           },
-      text: text ?? textBuilder.map((cb) => cb(error)),
+      text: text ?? textBuilder.map((cb) => cb(error, err)),
       type: switch (err) {
-        ErrorCode.notFound => QuickAlertType.warning,
+        ErrorCode.notFound ||
+        ErrorCode.forbidden ||
+        ErrorCode.unknown =>
+          QuickAlertType.warning,
         _ => QuickAlertType.error,
       },
       showCancelBtn: true,
       showConfirmBtn: false,
       cancelBtnText: lang.back,
       borderRadius: borderRadius,
     );
+
     onRetryTap.map((cb) {
       options.showConfirmBtn = true;
       options.confirmBtnColor = theme.primaryColor;

app/lib/common/toolkit/errors/error_page.dart

@@ -1,4 +1,5 @@
 import 'package:acter/common/toolkit/errors/error_dialog.dart';
+import 'package:acter/common/toolkit/errors/util.dart';
 import 'package:flutter/material.dart';
 
 /// ErrorPage shows a full-screen error to the user (covering other internal errors)
@@ -14,7 +15,7 @@ class ErrorPage extends StatelessWidget {
 
   final String? title;
   final String? text;
-  final String Function(Object error)? textBuilder;
+  final ErrorTextBuilder? textBuilder;
   final bool includeBugReportButton;
 
   /// Dialog Border Radius

app/lib/common/toolkit/errors/inline_error_button.dart

@@ -1,5 +1,6 @@
 import 'package:acter/common/extensions/options.dart';
 import 'package:acter/common/toolkit/errors/error_dialog.dart';
+import 'package:acter/common/toolkit/errors/util.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_gen/gen_l10n/l10n.dart';
 
@@ -17,7 +18,7 @@ class ActerInlineErrorButton extends StatelessWidget {
 
   final String? dialogTitle;
   final String? text;
-  final String Function(Object error)? textBuilder;
+  final ErrorTextBuilder? textBuilder;
   final bool includeBugReportButton;
 
   const ActerInlineErrorButton({

app/lib/common/toolkit/errors/util.dart

@@ -1,12 +1,20 @@
+typedef ErrorTextBuilder = String Function(Object error, ErrorCode code);
+
 enum ErrorCode {
   notFound,
+  forbidden,
+  unknown,
   other;
 
   static ErrorCode guessFromError(Object error) {
     final errorStr = error.toString();
     // yay, string-based error guessing!
     if (errorStr.contains('not found')) {
       return ErrorCode.notFound;
+    } else if (errorStr.contains('[400 / UNKNOWN]')) {
+      return ErrorCode.unknown;
+    } else if (errorStr.contains('[403 / M_FORBIDDEN]')) {
+      return ErrorCode.forbidden;
     }
     return ErrorCode.other;
   }

app/lib/common/utils/utils.dart

@@ -113,6 +113,10 @@ List<String> asDartStringList(FfiListFfiString data) {
   return data.toList().map((e) => e.toDartString()).toList();
 }
 
+extension FfiListFfiStringtoDart on FfiListFfiString {
+  List<String> toDart() => asDartStringList(this);
+}
+
 double? calcGap(BuildContext context) {
   // ignore: deprecated_member_use
   final double scale = MediaQuery.textScalerOf(context).textScaleFactor;

app/lib/common/widgets/room/room_hierarchy_join_button.dart

@@ -9,7 +9,7 @@ class RoomHierarchyJoinButton extends ConsumerWidget {
   final String roomId;
   final String joinRule;
   final String roomName;
-  final String? viaServerName;
+  final List<String>? viaServerName;
 
   const RoomHierarchyJoinButton({
     super.key,
@@ -42,14 +42,16 @@ class RoomHierarchyJoinButton extends ConsumerWidget {
           message: lang.youAreAbleToJoinThisRoom,
           child: OutlinedButton(
             onPressed: () async {
-              await joinRoom(
-                context,
-                ref,
-                lang.tryingToJoin(roomName),
-                roomId,
-                viaServerName,
-                forward,
+              final newRoomId = await joinRoom(
+                context: context,
+                ref: ref,
+                roomIdOrAlias: roomId,
+                serverNames: viaServerName,
+                roomName: roomName,
               );
+              if (newRoomId != null) {
+                forward(newRoomId);
+              }
             },
             child: Text(lang.join),
           ),
@@ -58,14 +60,16 @@ class RoomHierarchyJoinButton extends ConsumerWidget {
           message: lang.youAreAbleToJoinThisRoom,
           child: OutlinedButton(
             onPressed: () async {
-              await joinRoom(
-                context,
-                ref,
-                lang.tryingToJoin(roomName),
-                roomId,
-                viaServerName,
-                forward,
+              final newRoomId = await joinRoom(
+                context: context,
+                ref: ref,
+                roomIdOrAlias: roomId,
+                serverNames: viaServerName,
+                roomName: roomName,
               );
+              if (newRoomId != null) {
+                forward(newRoomId);
+              }
             },
             child: Text(lang.join),
           ),

app/lib/features/chat/pages/sub_chats_page.dart

@@ -2,6 +2,7 @@ import 'package:acter/common/providers/room_providers.dart';
 import 'package:acter/common/providers/space_providers.dart';
 import 'package:acter/common/skeletons/general_list_skeleton_widget.dart';
 import 'package:acter/common/utils/routes.dart';
+import 'package:acter/common/utils/utils.dart';
 import 'package:acter/common/widgets/room/room_card.dart';
 import 'package:acter/common/widgets/room/room_hierarchy_card.dart';
 import 'package:acter/common/widgets/room/room_hierarchy_join_button.dart';
@@ -11,6 +12,7 @@ import 'package:acter/features/categories/providers/categories_providers.dart';
 import 'package:acter/features/categories/widgets/category_header_view.dart';
 import 'package:acter/features/chat/providers/chat_providers.dart';
 import 'package:acter/router/utils.dart';
+import 'package:acter_flutter_sdk/acter_flutter_sdk_ffi.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_gen/gen_l10n/l10n.dart';
 import 'package:flutter_riverpod/flutter_riverpod.dart';
@@ -167,7 +169,7 @@ class SubChatsPage extends ConsumerWidget {
         [];
     final remoteSubchats =
         ref.watch(remoteChatRelationsProvider(spaceId)).valueOrNull ?? [];
-    final entries = [];
+    final List<(SpaceHierarchyRoomInfo?, String)> entries = [];
 
     for (final subId in categoryModelLocal.entries) {
       if (knownChats.contains(subId)) {
@@ -229,7 +231,7 @@ class SubChatsPage extends ConsumerWidget {
                     joinRule: roomInfo.joinRuleStr().toLowerCase(),
                     roomId: roomId,
                     roomName: roomInfo.name() ?? roomId,
-                    viaServerName: roomInfo.viaServerName(),
+                    viaServerName: roomInfo.viaServerNames().toDart(),
                     forward: (spaceId) {
                       goToChat(context, spaceId);
                       ref.invalidate(spaceRelationsProvider(parentId));