Deep linking setup #2360

gnunicorn · 2024-11-10T13:07:26Z

This PR brings the infrastructure for deep-linking -- aka opening the App with custom provided links -- to Acter. Additionally, these links can also be shared via QR-Code and a corresponding QR-parsing facility is included.

Here as if a link was clicked:

PXL_20241122_164942060.TS.mp4

With QR code reader:

PXL_20241122_165422382.TS.mp4

Opening super invite via QR code:

PXL_20241122_165527734.TS.mp4

refs #2223 :

In particular this PR does:

codecov · 2024-11-10T15:44:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.86%. Comparing base (4e0dacf) to head (b1eb5c5).
Report is 67 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2360      +/-   ##
==========================================
+ Coverage   27.84%   27.86%   +0.02%     
==========================================
  Files         608      617       +9     
  Lines       41982    42261     +279     
==========================================
+ Hits        11688    11778      +90     
- Misses      30294    30483     +189

Flag	Coverage Δ
integration-test	`36.89% <ø> (+0.01%)`	⬆️
unittest	`20.06% <ø> (+0.11%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Currently translated at 100.0% (1135 of 1135 strings) Translation: Acter/App Translate-URL: http://weblate.acter.global/projects/acter-app/flutter-app/de/

gnunicorn · 2024-11-22T17:09:17Z

app/lib/features/deep_linking/utils.dart

+
+class ParsingFailed extends UriParseError {}
+
+UriParseResult parseUri(Uri uri) => switch (uri.scheme) {


Highly wrapped code, but just check the unit tests to understand the formats and what it does ...

gnunicorn · 2024-11-22T17:13:12Z

app/lib/features/main/providers/main_providers.dart

 import 'package:flutter_riverpod/flutter_riverpod.dart';

 final quickActionVisibilityProvider =
    StateProvider.autoDispose<bool>((ref) => false);
+
+final appLinks = AppLinks(); // AppLinks is singleton


global setup according to applinks plugin

gnunicorn · 2024-11-22T17:14:11Z

app/lib/features/main/widgets/bottom_navigation_widget.dart

@@ -41,7 +41,7 @@ class BottomNavigationWidget extends ConsumerWidget {
                bottomNavNar(ref),
                AnimatedContainer(
                  duration: const Duration(milliseconds: 300),
-                  height: showQuickActions ? 150 : 0,
+                  height: showQuickActions ? 180 : 0,


slightly more space for our new bottom bar.

gnunicorn · 2024-11-22T17:15:29Z

app/lib/features/settings/pages/settings_page.dart

+    return InkWell(
+      onTap: () => shouldGoReplacement
+          ? context.pushReplacementNamed(Routes.myProfile.name)
+          : context.pushNamed(Routes.myProfile.name),
+      child: Card(
+        shape: RoundedRectangleBorder(
+          borderRadius: BorderRadius.circular(16),
+        ),
+        child: Column(
+          children: [
+            ListTile(
+              leading: ActerAvatar(
+                options: AvatarOptions.DM(accountInfo),
+              ),


Refactorted the UserHeader card a bit for usability:

trailing now has the QR-code button

the entire area is now clickable to get into the profile edit

gnunicorn · 2024-11-22T17:16:27Z

app/lib/features/users/actions/show_global_user_dialog.dart

+import 'package:acter/features/users/widgets/user_info_drawer.dart';
+import 'package:flutter/material.dart';
+
+const Key userInfoDrawer = Key('users-widgets-user-info-drawer');


mostly copy of the member-info-drawer section but adapted to our profile (which might even be missing) and doesn't have any room.

gnunicorn · 2024-11-22T17:16:49Z

app/lib/features/users/providers/user_profile_provider.dart

+final globalUserProfileProvider =
+    FutureProvider.family<UserProfile?, String>((ref, userId) async {
+  final client = ref.watch(alwaysClientProvider);
+  return (await client.searchUsers(userId)).toList().firstOrNull;


trying to find a user-id without any additional info goes over the search.

gnunicorn · 2024-11-22T17:17:20Z

app/lib/features/users/widgets/message_user_button.dart

@@ -10,18 +10,20 @@ import 'package:flutter_riverpod/flutter_riverpod.dart';
 import 'package:go_router/go_router.dart';

 class MessageUserButton extends ConsumerWidget {


moved and simplified to work in both room-member and global-user-scenarios ...

gnunicorn · 2024-11-22T17:17:56Z

app/lib/features/users/widgets/user_info_drawer.dart

+
+final _log = Logger('a3::user::user_info_drawer');
+
+class _UserInfoDrawerInner extends ConsumerWidget {


mostly a copy of the member_info_drawer. Just simplified and removed a few things we never have here.

gnunicorn · 2024-11-22T17:20:07Z

app/test/features/deep_linking/parsing_test.dart

+import 'package:acter/features/deep_linking/utils.dart';
+import 'package:flutter_test/flutter_test.dart';
+
+void main() {


these are all the parsing tests

kumarpalsinh25

Very Nicee! Most awaited feature which boost-up user engagement. 🚀 🥳

Code is well structured with very good base setup for deep-linking. 👏

Can I have screen-recording for iOS devices deep-link example? I hope apple-app-site-association-json-file related stuff is configured and deep linking on iOS working fine which all the use-cases.

.changes/2360-deep-linking.md

app/lib/features/deep_linking/actions/handle_deep_link_uri.dart

app/linux/packaging/global.acter.a3.desktop

app/linux/my_application.cc

kumarpalsinh25 · 2024-11-24T13:51:52Z

app/lib/features/space/widgets/space_toolbar.dart

+        // disabled until we have the proper reading facilities ready, See #2373
+        // QrCodeButton(
+        //   qrCodeData: 'matrix:roomid/${spaceId.substring(1)}',
+        // ),


Can't we put this when it is ready?

as 2373 is running around at the same time, there is still a chance this can land here. but if not, sure, I can remove this before merging.

gnunicorn · 2024-11-25T10:03:10Z

Can I have screen-recording for iOS devices deep-link example? I hope apple-app-site-association-json-file related stuff is configured and deep linking on iOS working fine which all the use-cases.

yes, an iOS setup did exist -- though not yet the associated domains, as a) I can't do that on matrix.to and b) we didn't yet take over app.acter.global - this comes in the next step(s). but as I had to redo the certificate signing part, I am not sure this is still the case ... let me confirm this again.

gnunicorn added 8 commits November 10, 2024 15:42

Add app links

35e45c1

Add Android config

b9c7c10

Disable in iOS setup

d296637

Setup Windows App Linking

1e36753

MacOS deep link support

09922ef

Linux support for custom schemes

8fb704d

Move AppShell

dd016e3

Print deep linked for testing

34e9130

gnunicorn force-pushed the ben-deep-linking-setup branch from 1c9a95c to 34e9130 Compare November 10, 2024 15:42

gnunicorn and others added 20 commits November 10, 2024 16:30

DeepLinking parsing matrix:-uri

243687e

Add support for matrix.to urls

54ea8fb

acter object links

6f8582e

Merge remote-tracking branch 'origin/main' into ben-deep-linking-setup

ed8100f

super invite support

7e4f0e5

qr-code support for invites

6c83521

User QRcode

39245e7

space access qrcode

d84f1da

QRcode reading

cecb9ec

dart fixup

461676b

Add info preview support on parser

3ec15d4

Reedeeming Super Invites UI support

2322195

New Build Certs export

d45f0c4

Translated using Weblate (German)

aa01f93

Currently translated at 100.0% (1135 of 1135 strings) Translation: Acter/App Translate-URL: http://weblate.acter.global/projects/acter-app/flutter-app/de/

Fixes, #2356

4ba4fee

Fixes, #2362

fad03ba

Fixes, #1704

c4deaae

Fixes,#2351

9055878

Fixes, #2358

3543a5d

Add changelog data

4d7bc2a

gnunicorn and others added 14 commits November 22, 2024 15:25

Test ensuring empty section of spaces list renders fine

92e0785

Rename Front -> First

f624515

Test ensuring our space search works find

17a96ef

Simplifying refactor

6aafce0

Releasing v1.24.11140

4f2616e

Mac App Certificates

4a5466e

Merge remote-tracking branch 'origin/main' into ben-deep-linking-setup

19e10fd

User Id sharing and parsing support

ddc26fa

Also react to matrix.to-links

543a0ba

Wire up uri parsing code with incoming activities

e293596

Fixup switch check format

6ca5d1d

Disable space QR button

ebe12b4

Also react to matrix.to-links

ad26a66

Fix l10n, formatting

db5fd55

gnunicorn commented Nov 22, 2024

View reviewed changes

gnunicorn marked this pull request as ready for review November 22, 2024 17:25

fixing buildcontext gapping

dc1e625

gnunicorn requested review from kumarpalsinh25, bitfriend and gtalha07 and removed request for bitfriend and kumarpalsinh25 November 22, 2024 17:34

Add Changelog

0f0827a

kumarpalsinh25 approved these changes Nov 24, 2024

View reviewed changes

gnunicorn added 2 commits November 26, 2024 13:02

Review cleanups

0f7e1e2

Merge remote-tracking branch 'origin/main' into ben-deep-linking-setup

b1eb5c5

gnunicorn merged commit 0a863be into main Nov 26, 2024
23 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deep linking setup #2360

Deep linking setup #2360

gnunicorn commented Nov 10, 2024 •

edited

Loading

codecov bot commented Nov 10, 2024 •

edited

Loading

gnunicorn Nov 22, 2024

gnunicorn Nov 22, 2024

gnunicorn Nov 22, 2024

gnunicorn Nov 22, 2024

gnunicorn Nov 22, 2024

gnunicorn Nov 22, 2024

gnunicorn Nov 22, 2024

gnunicorn Nov 22, 2024

gnunicorn Nov 22, 2024

kumarpalsinh25 left a comment

kumarpalsinh25 Nov 24, 2024

gnunicorn Nov 25, 2024

gnunicorn Nov 26, 2024

gnunicorn commented Nov 25, 2024 •

edited

Loading


		class ParsingFailed extends UriParseError {}

		UriParseResult parseUri(Uri uri) => switch (uri.scheme) {

		@@ -10,18 +10,20 @@ import 'package:flutter_riverpod/flutter_riverpod.dart';
		import 'package:go_router/go_router.dart';

		class MessageUserButton extends ConsumerWidget {


		final _log = Logger('a3::user::user_info_drawer');

		class _UserInfoDrawerInner extends ConsumerWidget {

Deep linking setup #2360

Deep linking setup #2360

Conversation

gnunicorn commented Nov 10, 2024 • edited Loading

codecov bot commented Nov 10, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kumarpalsinh25 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gnunicorn commented Nov 25, 2024 • edited Loading

gnunicorn commented Nov 10, 2024 •

edited

Loading

codecov bot commented Nov 10, 2024 •

edited

Loading

gnunicorn commented Nov 25, 2024 •

edited

Loading