-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 5.x #338
Update to 5.x #338
Conversation
Fixes for PHPStan & PHP CS Fixer
Update README.md
Remove PUT from the available item operations for the custom_objects endpoint
Fix test case
MAUT-11028 : fix segement filter issue in custom object
Co-authored-by: Saurabh Gupta <[email protected]>
MAUT-10983 : fix for custom item PATCH request is working same as PUT call
MAUT-8990 : Upgrade to PHP8
Simplified Guide: Installing Custom Objects Plugin for Mautic 5.1.1 Al following steps are done locally in your computer before you even go to mautic instance. Step 1: Clone the Plugin and Apply Compatibility Changes
Step 2: Prepare the Plugin for Upload
Step 3: Upload and Extract on Mautic Server
Step 4: Install the Plugin in Mautic
IMPORTANT STEP: I had error 500, to fix it you need to manually run this command:
o You should see output confirming that 1 plugin was installed.
Step 5: Verify Plugin Installation
Final Notes
After all this you will have CustomObjectsBundle running for Mautic 5 version. |
@escopecz I fixed the problems after analyzing the cs fixer program. So far, three (cs, twig, phpunit) of the five tasks are working fine locally. Phpstan and rector failed. Do I need to fix all of them? Or is it possible to create a baseline for phpstan for example? |
@volha-pivavarchyk yes, let's generate a baseline file for the PHPSTAN issues. |
@escopecz Could you please approve CI running |
@escopecz Could you please approve CI running One question. For fixing the failed
WDYT? |
@volha-pivavarchyk I opened mautic/mautic#14437 to fix the tabs not appearing on Contacts when loaded via AJAX. The viewName was missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using this on our branch with couple of our modifications.
It works as expected.
I recommend merge it to 5.x and continue improving it directly.
@driskell Thanks! I'll test it this evening |
Description:
Replaces PRs #298, #308, #316
Steps to test this PR: