Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-1399: Evaluate Composer 2.0 readiness. #4088

Merged
merged 9 commits into from
May 7, 2020
Merged

DT-1399: Evaluate Composer 2.0 readiness. #4088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b6ff94c
DT-1399: Evaluate Composer 2.0 readiness.
danepowell Mar 31, 2020
0e38b94
Merge branch '12.x' into DT-1399
danepowell Apr 20, 2020
ea83838
Update composer/installers.
danepowell Apr 20, 2020
8ed0c21
Merge remote-tracking branch 'upstream/12.x' into DT-1399
danepowell Apr 20, 2020
a812c67
Moved phpcs composer installer to dev.
danepowell Apr 20, 2020
714d36c
Removed composer patches.
danepowell Apr 20, 2020
53479d0
Removed grasmash/drupal-security-warning.
danepowell Apr 20, 2020
6b18d79
Merge branch '12.x' into DT-1399
danepowell Apr 27, 2020
d339c58
Merge remote-tracking branch 'upstream/12.x' into DT-1399
danepowell May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,27 +19,24 @@
"php": ">=7.3",
"ext-json": "*",
"acquia/drupal-environment-detector": "*",
"composer-plugin-api": "^1.1.0",
"composer-plugin-api": "^1.1.0 || ^2.0",
"composer/semver": "^1.4",
"consolidation/comments": "^1.0",
"consolidation/config": "^1.0.0",
"consolidation/robo": "^1.4.12 || ^2",
"cweagans/composer-patches": "^1.6.5",
Copy link
Member

@wimleers wimleers May 11, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge BC break and caused more than a dozen of hours of time spent debugging acquia/acquia_migrate#184 😭

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to cause you grief, but just to be clear this only happened in the 12.x branch which is explicitly unstable and unsupported. However we just cut 12.0.0-alpha1 and I don't foresee any more BC breaks, although they could still happen.

Copy link
Contributor Author

@danepowell danepowell May 11, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I suppose this is an example of the paradigm that if you rely on a dependency, you should declare it, even if you already get it "for free" from some upstream package. You might want to see what else BLT is providing that you rely on, and make sure that you explicitly declare the dependency yourself.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but just to be clear this only happened in the 12.x branch which is explicitly unstable and unsupported

But we're explicitly building a stable product on top of Drupal 9 over at https://github.com/acquia/migrate.

We must use https://github.com/acquia/orca.

https://github.com/acquia/orca requires us to use https://github.com/acquia/blt, and specifically version 12 to test with Drupal 9.

So I don't see how we have any choice here?

I think we can be pragmatic here: explicitly ping me whenever there's a BC break being introduced in BLT 12, so that we can make whatever changes we need to not break the build, or only break it for a brief period of time :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I suppose this is an example of the paradigm that if you rely on a dependency, you should declare it, even if you already get it "for free" from some upstream package.

This is totally fair! :)

"dflydev/dot-access-data": "^1.1.0",
"doctrine/common": "^2.5",
"drupal/coder": "^8.3.1",
"drupal/core": "^9.0.0-alpha1",
"drupol/phposinfo": "^1.6",
"drush/drush": "^10.2.2",
"grasmash/drupal-security-warning": "^1.0.0",
"grasmash/yaml-cli": "^2.0.0",
"grasmash/yaml-expander": "^1.2.0",
"sensiolabs/security-checker": "^5.0.0",
"symfony/config": "^4.4",
"symfony/console": "^4.4.6",
"symfony/twig-bridge": "^3.3",
"symfony/yaml": "^4.4",
"zaporylie/composer-drupal-optimizations": "^1.0",
"zumba/amplitude-php": "^1.0"
},
"conflict": {
Expand All @@ -48,7 +45,7 @@
"require-dev": {
"acquia/coding-standards": "^0.4.0",
"composer/composer": "^1.6.4",
"composer/installers": "^1.2.0",
"composer/installers": "^1.9.0",
"dealerdirect/phpcodesniffer-composer-installer": "^0.5.0",
"drupal/core-dev": "^9.0.0-alpha1",
"knplabs/github-api": "^2.6",
Expand All @@ -73,7 +70,6 @@
"10.x-dev": "10.0.x-dev"
},
"class": "Acquia\\Blt\\Composer\\Plugin",
"composer-exit-on-patch-failure": true,
"installer-paths": {
"vendor/drupal/core": [
"type:drupal-core"
Expand Down
143 changes: 2 additions & 141 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.