Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/project rewrite #219

Closed
wants to merge 11 commits into from
Closed

Feature/project rewrite #219

wants to merge 11 commits into from

Conversation

acouvreur
Copy link
Owner

@acouvreur acouvreur commented Oct 22, 2023

Full rewrite which will be version 2.0 which will provide more friendly go apis

@ab623
Copy link

ab623 commented Jan 5, 2024

How is the rewrite going? Keen to see the improved version!

@acouvreur
Copy link
Owner Author

Almost everything is finished
I started working on the UI but I'm working at a very slow pace right now.
I have my main focus on different things.

I will probably release the rewrite to beta first and add the UI afterwards.

Overall system is more stable and resilient.

It's more like a developer experience rewrite also, as Sablier is one of my first big project in Go, I've developed the project with Java enterprise habits which I'm trying to fix in the rewrite branch.

Feel free to dive in.

I'll update this draft to add a to-do list up to date with the project :)

@justmiles
Copy link

Hey @acouvreur, this is looking great. I've added a provider for Nomad and am cleaning a few things up before submitting a PR. Should I wait for this refactor?

@acouvreur
Copy link
Owner Author

Hey @acouvreur, this is looking great. I've added a provider for Nomad and am cleaning a few things up before submitting a PR. Should I wait for this refactor?

Hello @justmiles, thanks for your contribution! It looks really promising!

I think you can target the beta branch, and I will do the migration myself to new project rewrite

@github-actions github-actions bot added the Stale label Mar 7, 2024
@github-actions github-actions bot closed this Mar 12, 2024
@ab623
Copy link

ab623 commented Mar 29, 2024

Should this be closed? Surely it should stay open until the rewrite is complete.

@acouvreur acouvreur reopened this Mar 30, 2024
@acouvreur
Copy link
Owner Author

Yes you're right, the bot was a bit aggressive on issues and PRs.

@github-actions github-actions bot removed the Stale label Mar 30, 2024
@acouvreur
Copy link
Owner Author

Actually, this is a common developper mistake, instead of changing the project piece by piece I wanted to move it all at once and now it's overwhelming!

I've started integrating a lot of the feature in this branch as small PRs.

I will keep doing that and close this PR :)

@acouvreur acouvreur closed this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants