Merge pull request #10 from acnicholls/develop

final workflow test check
acnicholls · Oct 19, 2024 · 90f1d02 · 90f1d02
2 parents 6aa7028 + f8f75ff
commit 90f1d02
Showing 1 changed file with 8 additions and 29 deletions.
diff --git a/.github/workflows/create-release-with-asset.yml b/.github/workflows/create-release-with-asset.yml
@@ -91,33 +91,6 @@ jobs:
           script: |
             core.setFailed('user-installer build failed, no sense continuing...')
 
-      # zip the build output
-      - name: zip build artifact
-        id: zip-build-artifact
-        run: |
-          7z a -tzip ${{ github.workspace }}\Build_Release.zip ${{ github.workspace }}\Solution\TrangTestStub\bin\Release\*
-
-      # send build output to github output
-      - name: Upload Build Artifact
-        id: upload-build-artifact
-        uses: actions/upload-artifact@v4
-        with:
-          name: build-executable-artifact
-          path: ${{ github.workspace }}\Build_Release.zip
-          retention-days: 5
-
-      # upload build output to release
-      - name: Upload Release Asset
-        id: upload-release-asset
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        uses: actions/upload-release-asset@v1
-        with:
-          upload_url: ${{ needs.create-release.outputs.release-asset-upload-url }}
-          asset_path: ${{ github.workspace }}\Build_Release.zip
-          asset_name: Build_Release.zip
-          asset_content_type: application/zip
-
       # send build output to github output
       - name: Upload Build Artifact
         id: upload-build-artifact-2
@@ -127,14 +100,20 @@ jobs:
           path: ${{ github.workspace }}\Solution\TrangTestStub\bin\Release\*
           retention-days: 5
 
+      # zip the build output
+      - name: zip build artifact
+        id: zip-build-artifact
+        run: |
+          7z a -tzip ${{ github.workspace }}\Build_Release.zip ${{ github.workspace }}\Solution\TrangTestStub\bin\Release\*
+
       # upload build output to release
       - name: Upload Release Asset
-        id: upload-release-asset-2
+        id: upload-release-asset
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         uses: actions/upload-release-asset@v1
         with:
           upload_url: ${{ needs.create-release.outputs.release-asset-upload-url }}
-          asset_path: ${{ steps.upload-build-artifact-2.outputs.artifact-url }}
+          asset_path: ${{ github.workspace }}\Build_Release.zip
           asset_name: Build_Release.zip
           asset_content_type: application/zip