Feature: Add new version API dns SELECTEL dns_selectel.sh (actual v2) #5128
Conversation
|
Welcome |
vlad-kms
changed the title
vlad-kms
changed the title
|
Tests: https://github.com/vlad-kms/acme.sh/actions |
Tests: https://github.com/vlad-kms/acme.sh/actions |
|
as i understand, comments should be on english, so others can understand it. but anyway, this is good one! |
Translated comments into English. Sorry, I don’t know the language, Google translated it worked. |
|
@vlad-kms You have a typo in the case of the character of the name of the variable SL_Login_name, which is used in the comments to the account.conf file. This will result in the exception "You did not specify the selectel.ru API service username." for anyone who will follow the instructions. |
Sorry! Corrected in the comments |
Please tell me, did you replace the variable name with SL_Login_Name, checked after that? |
Yes, I fixed and checked it locally, everything works. Sorry for the long answer, I did not enter this request after that. |
|
@vlad-kms @rzolotuhin Hello. Guys, if I understand correctly, everything works. And did you pass the tests? Продублирую на русском. Не очень понимаю, почему все остановилось, я так понимаю все тесты пройдены, перенес все на новый DNS-хостинг, и старый API уже не работает (((( |
@alekho
|
Благодарю! |
|
@vlad-kms , Hi, it's not worked for me. Or I just don't understand how I can make it work... I have put the file into acme.sh directory of my docker and ran "acme.sh --issue --dns dns_selectel -d --keylength 2048". I've pointed SL_Ver="v2" but it still use "v1" because asked me to point the SL_Key "You don't specify selectel.ru api key yet.". And I've pointed it. Then I got "invalid domain". Now I don't now what else can I do. I've tried with 2 and 3 level domains it's the same. |
I figured out what was going on. it was necessary to properly mount the docker folder with apidns and put the updated dns_selectel file there. Everything is working now. P.S. I'm using acme.sh docker on Synology. |
|
Thank you, good thing we figured it out. And it works with wildcard |
|
Hello, is there any news about this PR? |
|
I have been using this change for a long time, and everything works perfectly. Selectel has announced that the old version of the protocol will no longer be supported: https://hosting.kitchen/selectel/vazhnaya-informaciya-o-zavershenii-podderzhki-legacy-dns-hostinga.html (Unfortunately, Selectel does not publish this information on their website and only sends it via email). Давно пользуюсь этим изменением и всё работает отлично. |
What's wrong here? Everything seemed to work. |
dnsapi/dns_selectel.sh
Outdated
| return 1 | ||
| fi | ||
|
|
||
| _debug3 SL_Ver "$SL_Ver" |
There was a problem hiding this comment.
don't use debug3, please use debug2
There was a problem hiding this comment.
fix. Replaced 'debug3' with 'debug2'
| @@ -1,14 +1,29 @@ | |||
| #!/usr/bin/env sh | |||
| # shellcheck disable=SC2034 | |||
There was a problem hiding this comment.
I mean keep these content:
dns_selectel_info='Selectel.com
Domains: Selectel.ru
Site: Selectel.com
Docs: github.com/acmesh-official/acme.sh/wiki/dnsapi#dns_selectel
Options:
SL_Key API Key
'
There was a problem hiding this comment.
Corrected and left this content
| _domain=$h | ||
| _debug "Getting domain id for $h" | ||
| if ! _sl_rest GET "/$h"; then | ||
| i=2 |
There was a problem hiding this comment.
@Neilpang
Here the parent domain is calculated in a loop. And in this algorithm, the first step must start with 2, not 1. Why check the record, for example _acme-challenge.dom2.dom1.ru. And it is checked right away dom2.dom1.ru
There was a problem hiding this comment.
I know what it's doing. make it start from 1.
because we need to support dns alias mode:
https://github.com/acmesh-official/acme.sh/wiki/DNS-alias-mode
There was a problem hiding this comment.
I know what it's doing. make it start from
1. because we need to support dns alias mode: https://github.com/acmesh-official/acme.sh/wiki/DNS-alias-mode
Sorry! I only read the phrase "Don't use the domain name only for --domain-alias", and then missed it
I corrected and checked both --challenge-alias and --domain-alias , but only for api version v2. I didn't change it for v1 because there is no way to check. I transferred all my domains to v2 , but I can't add a new domain for the legacy version. And then, this algorithm for v1 was taken from the old file, and it starts with 2.
|
update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi#dns_selectel |
And here you can't edit after the merge? I left this as a draft: If SL_Ver is "v1", You can view or create it in the control panel in the upper right corner, by opening the Profile and settings -> API keys menu. If SL_Ver is "v2", then you need to define the following variables export SL_Expire=60 -- token lifetime in minutes (0-1440). export SL_Login_ID=<account_id> -- account number in the control panel; export SL_Project_Name=<project_name> -- project name. export SL_Login_Name=<login_name> - service user name. You can see the name in the control panel: export SL_Pswd=<> -- User Password You can see the password either when creating a user, or change it to a new one. All these variables will be saved in ~/.acme.sh/account.conf and will be reused as needed. Note: legacy version of api v1 will be disabled from 09.2025 according to the support service |
|
edit the usage before it's merged. |
…main-alias (only version api actual v2)
Edited by |
# dns_selectel_info='Selectel.com # Domains: Selectel.ru # Site: Selectel.com # Docs: github.com/acmesh-official/acme.sh/wiki/dnsapi#dns_selectel # Options: # Variables that must be defined before running
# dns_selectel_info='Selectel.com # Domains: Selectel.ru # Site: Selectel.com # Docs: github.com/acmesh-official/acme.sh/wiki/dnsapi#dns_selectel # Options: # Variables that must be defined before running
This set of changes expands the existing Selectel DNS API script dns_selectel.sh to support the Selectel API version v2 (actual).
Now SELECTEL simultaneously works with two versions of the API: legacy DNS API and actual DNS API (new). The goal is to allow SELECTEL users to use the script for two versions.
https://developers.selectel.ru/docs/cloud-services/dns_api/dns_api_actual/
Issue: #5126
For existing installations where only the old version of the API (legacy) is used, nothing will have to be reconfigured and nothing needs to be done for older versions.
Variables that need to be controlled before starting:
export SL_Ver="v1" -- version API: 'v2' (actual) or 'v1' (legacy).
default: v1
If SL_Ver is equal "v1", then you need to define the variable
export SL_Key="API_KEY" -- token Selectel (API key)
You can view or create it in the control panel in the upper right corner, open the Profile and Settings menu -> API Keys.
https://my.selectel.ru/profile/apikeys
If SL_Ver is equal "v2", then you need to define the following variables
export SL_Expire=60 -- token lifetime in minutes (0-1440).
default: 1400 minutes
export SL_Login_ID=<account_id> -- account number in the control panel;
export SL_Project_Name=<project_name> -- name project.
export SL_Login_Name=<login_name> - service user name.
You can view the name in the control panel:
in the upper right corner, open the menu ? Profile and settings ? User management section ? Service users tab
export SL_Pswd=<> - The service user password can be viewed when creating a user or changed to a new one.
All these variables will be saved in ~/.acme.sh/account.conf and will be reused as needed.
Tests: https://github.com/vlad-kms/acme.sh/actions
For two versions:
test DNS for v1 (legacy) - for version API DNS legacy
test DNS for v2 (actual) - for version API DNS actual (new)