Changes misnamed :__absinthe_type_import__ to :__absinthe_type_imports__ in Schema.Notation
#1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Goldberger <[email protected]>
|
@elbow-jason hey thanks! I'll have to look at this more closely but it does look like tests are failing in the CI, do you see them passing locally? |
|
@benwilson512 They are most definitely not passing locally. This PR needs a little more love before it's ready. |
|
I think the existing behavior was intended, and the fact that the accumulating attribute was mis-spelled was actually what made it work correctly, since the code seems to manually manage the "default" empty list case... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes a (probably) misnamed module attribute registered during the compilation of
use Schema.Notation.Closes #1119
Signed-off-by: Jason Goldberger [email protected]