Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify unique_ptr lifetime #490

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

cbachhuber
Copy link

In @marcdiepold's opinion, the wording should be more specific here. If you don't move anything, the std::unique_ptr and its contents will vanish when the enclosing scope ends. We argue that this is the case for the vast majority of std::unique_ptr data members, thus the unrestricted lifetime should be further specified here.

Copy link

google-cla bot commented Sep 13, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@cbachhuber cbachhuber changed the title Specific unique_ptr lifetime Specify unique_ptr lifetime Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants