Add call and recenter option under ivy-hydra 'calling' #2945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would be a generalized solution for abo-abo#2838 I guess
dalanicolai
commented
Jan 13, 2022
| @@ -1515,7 +1519,7 @@ See variable `ivy-recursive-restore' for further information." | |||
| (interactive) | |||
| (ivy-call) | |||
| (with-ivy-window | |||
| (recenter-top-bottom))) | |||
There was a problem hiding this comment.
This function does not recenter exclusively but, in the simplest case, alternates between top, center,
and bottom (which is not consistent with its docstring, I think)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like a recenter option (like when calling
ivy-call-and-recenter), but then combined with 'previous/next line' option.I think this PR is probably the fastest way to achieve it. Let me know if you are interested and then how to modify it and where
to update the docs, so I can update the PR.
This would be a generalized solution for #2838, and a few other issues, I guess