Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CI #34

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Simplify CI #34

merged 2 commits into from
Mar 13, 2024

Conversation

aazuspan
Copy link
Owner

Closes #33 indirectly by updating the EE token for the repository to include the entire credential. In the process, I simplified the CI scripts and fixed a broken test caused by an update to earthengine-api that changed the repr for ee.Projection objects.

It looks like the string repr for `ee.Projection` changed to
`ee.projection.Projection`, so my check for the fallback repr
started failing. Just updated that to match the new repr.
@aazuspan aazuspan added the bug Something isn't working label Mar 13, 2024
@aazuspan aazuspan self-assigned this Mar 13, 2024
@aazuspan aazuspan merged commit c439adb into main Mar 13, 2024
6 checks passed
@aazuspan aazuspan deleted the simplify-ci branch March 13, 2024 22:45
@grovduck
Copy link

@aazuspan, I just came upon the same credential issue when CI testing lemma-osu/gee-knn-python#7. Is it just a matter of copying the JSON at my ~/.config/earthengine/credentials into the Github secret? I assume that it was just a string previously?

@aazuspan
Copy link
Owner Author

Exactly! It was previously just the refresh_token, but it looks like the whole credential is required now.

You might've noticed I also snagged your clever echo trick for writing the credentials 😄

@grovduck
Copy link

Sweet, thank you! I just started rerunning tests and they seem to be working.

You might've noticed I also snagged your clever echo trick for writing the credentials 😄

I did see that, but I'm sure you likely helped me with that or I lifted it from elsewhere!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix failing CI
2 participants