Add numberOfLines, lineHeight options; create flatSizes; increase accuracy #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have some Text components that
numberOfLines
prop to limit lineslineHeight
style to change from the default line heightWe want to measure their height using
flatHeights
.This also increases accuracy for both iOS and Android by fixing tiny discrepancies.
Fix
numberOfLines
andflatHeights
. This matches the<Text numberOfLines={...}>
propflatSizes
function that behaves the same asflatHeights
, but returns both the width and height. We use arrays (instead of objects with width and height) to reduce the amount key data passed over the React Native bridgeTesting
Created Storybook story in our app to test it on both Android and iOS: