Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(r1cs): We add a range check to the chunk #526

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mw2000
Copy link
Contributor

@mw2000 mw2000 commented Dec 16, 2024

Should solve #512

Copy link
Collaborator

@moodlezoup moodlezoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for looking into this Mihir! This approach works, but I think for performance reasons we'd prefer to use Lasso-style range checks (similar to what we do in timestamp_range_check.rs). Justin also has some ideas on how we could do them even more efficiently, so I was planning on tackling these range checks myself in the coming weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants