-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Productionize JavaScript and NPM #392
Draft
roninjin10
wants to merge
10
commits into
a16z:operation-solar-storm
Choose a base branch
from
evmts:willc/npm
base: operation-solar-storm
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* generic execution client * feat: generic consensus * wip * crate refactor * fmt * cleanup redundant modules * clean up reexports * clean up ethereum lib exports * fix rpc socket handling * fix tests * ci * remove unused clone * fix transaction builder * remove stub directories
* add lc server * add client * add builder * add config * add server cli * fix rpc socket defaults * change rpc defaults * better block safety
* feat: wasm support for all networks * cleanup
* wip * feat: add execution block backfill * handle finalized blocks * cleanup * fix timing in wasm * remove web_sys from core * typo * rebase fixes
update webpack config copy everything over format and fix everything workflow finish
roninjin10
commented
Oct 12, 2024
"format:check": "biome format .", | ||
"lint": "biome check . --write --unsafe", | ||
"lint:check": "biome check . --verbose", | ||
"lint:package": "bunx publint --strict && attw --pack --ignore-rules cjs-resolves-to-esm", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
"lint:package": "bunx publint --strict && attw --pack --ignore-rules cjs-resolves-to-esm", | |
"lint:package": "npx bunx publint --strict && attw --pack --ignore-rules cjs-resolves-to-esm", |
Copy pasta this should be npx since this repo isn’t using bun
ncitron
force-pushed
the
operation-solar-storm
branch
from
October 23, 2024 23:03
ee12436
to
1d1b50b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds npm publishing and generally updates the javascripts to be more robust
.gitattributes
Ignore some generated files in future github diffs
publish.yml
Runs basic checks like linters before publishing. By default it does a
dry-run
which means it tests that npm publishing will work but doesn't actually publish. To publish you must trigger a publish via a workflow action.release.yml
Must have been a bad rebase because this
helios-ts/biome.json
Configures the biome linter to lint and format the ts package. I tried to configure it as much as the code was already formatted as possible.
helios-ts/docs
Generated docs that can be genrated via
npm run docs
helios-ts/package.json
Updated package.json in many ways to robustly be ready to publish to npm
Note: type: module means instead of using commonjs
require()
andmodule.exports
you must use modern esm syntax nowimport foo from 'foo.js' and export default
helios-ts/tsconfig.json
npx tsc --noemit
would breakNote: node next requires us to add .js file extension to our files
helios-ts/typedoc.json
Copy pasted a typedoc.json file in for the docs generation
helios-ts/webpack.config.js
Updated the webpack config to generate both esm and cjs for universal compatibility