Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume Control, UI Update, and Bug Fixes #158

Merged
merged 5 commits into from
Aug 10, 2024
Merged

Volume Control, UI Update, and Bug Fixes #158

merged 5 commits into from
Aug 10, 2024

Conversation

a-mabe
Copy link
Owner

@a-mabe a-mabe commented Aug 1, 2024

TODO

  • Other audio paused by timer on iOS
  • Fix sound still playing when none selected
  • Use published background timer version

Added

  • Timer volume control, separate from system volume, closes [Feature/Improvement] Volume control #136.
    • Volume can be adjusted while a timer is actively running.
    • Volume is saved as a shared preference and will persist between timers.

Changed

  • UI for an actively running workout/timer.
    • Added a "control panel" to make room for additional controls.
    • Moved the pause button from the top right corner to the control panel.
    • Added a restart button that is available while the timer is running.
    • Volume control is available on the control panel.
  • Improved the landscape orientation UI, closes [Feature/Improvement] Landscape mode #157.

Fixed

  • Share External not working on iPad.
  • Setting sound effect to none not working.

@a-mabe a-mabe merged commit cdcd749 into main Aug 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature/Improvement] Landscape mode [Feature/Improvement] Volume control
1 participant