Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Contributing, correct Gitter & mention subreddit #2136

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sohang3112
Copy link

@sohang3112 sohang3112 commented Mar 14, 2024

Fixes Issue 2131

@sohang3112
Copy link
Author

@keikoro Please review & merge this PR - Gitter link in CONTRIBUTING.md is corrected, there are no code changes.

@sohang3112
Copy link
Author

@keikoro Please merge this PR

@keikoro
Copy link
Collaborator

keikoro commented Apr 23, 2024

@sohang3112 Adding the Reddit link is a nice thought, but I'm not aware that any of us admins – except for Zulko – ever looked at the sub to provide support. I'd very much not add it to official documentation because that will just set unrealistic expectations.

I'm not even sure the Gitter should still be on there as none of us check in there regularly AFAIA.

@keikoro
Copy link
Collaborator

keikoro commented Apr 23, 2024

@sohang3112 But ok, the Gitter link needs at least correcting. Please update the PR so it only includes the link fix and I'll merge it.

@sohang3112
Copy link
Author

sohang3112 commented Apr 23, 2024

Adding the Reddit link is a nice thought, but I'm not aware that any of us admins – except for Zulko – ever looked at the sub to provide support. I'd very much not add it to official documentation

The Reddit link is already there in the README. If it shouldn't be mentioned, then it should be removed from README also.

@sohang3112
Copy link
Author

@keikoro Should I remove Reddit link from both README.md and CONTRIBUTING.md in my PR?

As per discussion with @keikoro at Zulko#2136, the sub-reddit is not actively monitored so it should be removed.
@sohang3112
Copy link
Author

@keikoro Removed Reddit link from both README and CONTRIBUTING. Please check & merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid Gitter link in CONTRIBUTING.md
2 participants