Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding default behaviour for clips array when input shape isn't adequate #1932

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

EmreCenk
Copy link

@EmreCenk EmreCenk commented Mar 13, 2023

This PR Includes:

  • Implemented changes for clips_array default behaviour. Previously when a non-rectangular array was passed in ( ex: [ [1, 2], [3] ] ), it would throw an error. Now, the remaining space is just filled with the background color as default behaviour instead

Checklist:

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it

@mgaitan
Copy link
Collaborator

mgaitan commented Apr 1, 2023

@EmreCenk thank you very much for this first contribution. Please, consider fixing the broken tests and add at least one showing the case you are fixing with this change. Also, could you use a spellchecker in the docstring and comments?

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants