Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added orientation parameter to write_videofile #1913

Conversation

yemibox51
Copy link

@yemibox51 yemibox51 commented Feb 4, 2023

Fixing Issue #1911

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings

@yemibox51
Copy link
Author

When running the tests suite, getting 23 failed tests, this was before I made any changes. Also don't know how to get the pre-commit to work with python3.9 and without updating any of the config files.

@coveralls
Copy link

Coverage Status

Coverage: 84.513% (+0.8%) from 83.73% when pulling fdb92fa on yemibox51:yemibox51/bug_portrait-rendered-as-landscape into 858bb81 on Zulko:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants