Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/issues 631 632 #1910

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

koutoftimer
Copy link

I just did straightforward fix. No overthinking.

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it

Closes #631 #632
Related to #634

@koutoftimer
Copy link
Author

koutoftimer commented Feb 7, 2023

How the hell code format checks are fine for master branch and didn't work for my pull request if I haven't even touched that files?

@koutoftimer
Copy link
Author

Oh, I see, so code format issues aren't the only one. My bad.

@koutoftimer koutoftimer marked this pull request as draft February 13, 2023 17:02
@keikoro
Copy link
Collaborator

keikoro commented Feb 22, 2023

Heads-up: the most recent commit on master fixes the (recently) failing black check.

Also, some of the Windows checks + the Linux 3.6 check have been broken for a while now, so those have nothing to do with your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supersample Concatenated Clip
2 participants