Use audio_codec option even if audio is given as filename #1906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moviepy.video.VideoClip.write_videofile
ignoresaudio_codec
whenaudio
is a file name. I have fixed it in this PR.moviepy.video.VideoClip.write_videofile("output.mp4", audio="input.wav", fps=60, audio_codec="aac")
have runffmpeg
with-acodec copy
. With this PR, it will run the command with-acodec aac
.tests/