Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Gitter link in CONTRIBUTING.md #2131

Open
sohang3112 opened this issue Mar 8, 2024 · 4 comments · May be fixed by #2136
Open

Invalid Gitter link in CONTRIBUTING.md #2131

sohang3112 opened this issue Mar 8, 2024 · 4 comments · May be fixed by #2136
Labels
bug Issues that report (apparent) bugs. documentation Related to documentation in official project docs or individual docstrings. tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo.

Comments

@sohang3112
Copy link

In CONTRIBUTING.md, this Gitter link is mentioned for discussions: https://gitter.im/Movie-py . But opening the liink gives error 404 Not Found.
@sohang3112 sohang3112 added the bug Issues that report (apparent) bugs. label Mar 8, 2024
@keikoro
Copy link
Collaborator

keikoro commented Mar 8, 2024

I'm not sure if the Gitter is even actively being used anymore, but if the link is wrong, it should get corrected. The README containes the correct link.

@keikoro keikoro added tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo. documentation Related to documentation in official project docs or individual docstrings. labels Mar 8, 2024
@sohang3112
Copy link
Author

The Gitter link in README works: https://gitter.im/movie-py/Lobby - but it also doesn't seem to be actively used any more (as you said). Since the Reddit sub (https://www.reddit.com/r/moviepy/) is still active, it should also be added in CONTRIBUTING.md for discussions.

@sohang3112 sohang3112 linked a pull request Mar 14, 2024 that will close this issue
Open
@sohang3112
Copy link
Author

@keikoro Based on our discussion I opened the PR above to fix Gitter link & add Reddit link in CONTRIBUTING.md. Please review the PR & merge it.

@sohang3112
Copy link
Author

@keikoro Please review & merge my linked PR to correct Gitter link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issues that report (apparent) bugs. documentation Related to documentation in official project docs or individual docstrings. tooling Apps, integrations, workflows, tools... relevant to the maintenance of this project/repo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

In Contributing, correct Gitter & mention subreddit sohang3112/moviepy
2 participants
@keikoro @sohang3112