Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major version to work with Laravel 6 #958

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bakome
Copy link

@bakome bakome commented Sep 24, 2019

Updated all dependencies, migrations template and whole package in general in order to work with Laravel >=6 version.

@sam-mak-dream
Copy link

When will you merge and release this?

@chrisvickers
Copy link

Still waiting on this and can't move to laravel 6 without it. If we need to start looking out people to help out with management of this repo i am more than happy to help

Copy link

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully @Zizaco can take at this PR soon. 😓


matrix:
fast_finish: true
allow_failures:
- php: 7.0
- php: 7.3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this safer to put php: 7.2

Comment on lines -518 to -528
If you encounter an error when doing the migration that looks like:

```
SQLSTATE[HY000]: General error: 1005 Can't create table 'laravelbootstrapstarter.#sql-42c_f8' (errno: 150)
(SQL: alter table `role_user` add constraint role_user_user_id_foreign foreign key (`user_id`)
references `users` (`id`)) (Bindings: array ())
```

Then it's likely that the `id` column in your user table does not match the `user_id` column in `role_user`.
Make sure both are `INT(10)`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these changes to the readme file aren't necessary like removing of this and model namespacing.

@@ -162,7 +163,7 @@ public function can($permission, $requireAll = false)
foreach ($this->cachedRoles() as $role) {
// Validate against the Permission table
foreach ($role->cachedPermissions() as $perm) {
if (str_is( $permission, $perm->name) ) {
if (Str::is( $permission, $perm->name) ) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andrey-helldar
Copy link

Guys, it's a dead package. Use laravel-roles instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants