feat: Updated ADAPTER_LLMW_MAX_POLLS to 120 for 1 hour extraction #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandrasekharan-zipstack
requested review from
pk-zipstack
and removed request for
a team
|
|
ritwik-g
reviewed
Dec 18, 2024
| # 500 mins to allow 1500 (max pages limit) * 20 (approx time in sec to process a page) | ||
| ADAPTER_LLMW_MAX_POLLS=1000 | ||
| # ~60 mins (assuming it'll be enough to process 1500 pages with LLMW v2) | ||
| ADAPTER_LLMW_MAX_POLLS=120 |
There was a problem hiding this comment.
@chandrasekharan-zipstack but what about for the V1? Doesn't it use the same ENV?
There was a problem hiding this comment.
@ritwik-g you're right, v1 uses the same envs. Shall we discourage support for v1 by changing this env (reducing the time / max possible pages) and instead enforce support with v2 for more number of pages?
Realistically speaking - I doubt if any user has such large extraction times.
Worst case,
- either we'll have to let this env be and take action after we sunset v1
- or introduce a new set of envs for v2 and update that (involves changes in the SDK, so I'm not a fan of this)
| # 500 mins to allow 1500 (max pages limit) * 20 (approx time in sec to process a page) | ||
| ADAPTER_LLMW_MAX_POLLS=1000 | ||
| # ~60 mins (assuming it'll be enough to process 1500 pages with LLMW v2) | ||
| ADAPTER_LLMW_MAX_POLLS=120 |
There was a problem hiding this comment.
@chandrasekharan-zipstack Will this not cause timeout if it exceeds max 15min time which we have set in gunicorn ?
There was a problem hiding this comment.
@harini-venkataraman the timeout exists only for extractions that happens with a web UI. This large setting is mainly ideal for async pipeline based extractions where such gunicorn timeouts will not play a role
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Env Config
Related Issues or PRs
Notes on Testing
Checklist
I have read and understood the Contribution Guidelines.