-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/prompt key required field #885
base: main
Are you sure you want to change the base?
Conversation
backend/prompt_studio/prompt_studio_registry_v2/prompt_studio_registry_helper.py
Show resolved
Hide resolved
…into feat/prompt-key-required-field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vishnuszipstack is the tool tip to indicate that this is for HQR implemented here? I suggest added that before we merge this to avoid any confusions around this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: vishnuszipstack <[email protected]>
for more information, see https://pre-commit.ci
…into feat/prompt-key-required-field
|
Quality Gate passedIssues Measures |
What
Why
How
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.