[Fix] Handled client side network issues #833
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagadeeswaran-zipstack
requested review from
a team,
gaya3-zipstack,
kirtimanmishrazipstack,
tahierhussain,
Deepak-Kesavan,
athul-rs and
vishnuszipstack
and removed request for
a team
|
|
jagadeeswaran-zipstack
changed the title
Deepak-Kesavan
approved these changes
Nov 8, 2024
vishnuszipstack
requested changes
Nov 8, 2024
Comment on lines
+21
to
+35
| if (err.code === "ERR_NETWORK" && !navigator.onLine) { | ||
| return { | ||
| type: "error", | ||
| content: "Please check your internet connection.", | ||
| title: title, | ||
| duration: duration, | ||
| }; | ||
| } else if (err.code === "ERR_CANCELED") { | ||
| return { | ||
| type: "error", | ||
| content: "Request has been canceled.", | ||
| title: title, | ||
| duration: duration, | ||
| }; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (err.code === "ERR_NETWORK" && !navigator.onLine) { | |
| return { | |
| type: "error", | |
| content: "Please check your internet connection.", | |
| title: title, | |
| duration: duration, | |
| }; | |
| } else if (err.code === "ERR_CANCELED") { | |
| return { | |
| type: "error", | |
| content: "Request has been canceled.", | |
| title: title, | |
| duration: duration, | |
| }; | |
| } | |
| const getErrorMessage = (err, title, duration) => { | |
| const errorMessages = { | |
| ERR_NETWORK: "Please check your internet connection.", | |
| ERR_CANCELED: "Request has been canceled.", | |
| }; | |
| if (errorMessages[err.code]) { | |
| return { | |
| type: "error", | |
| content: err.code === "ERR_NETWORK" && !navigator.onLine ? errorMessages.ERR_NETWORK : errorMessages[err.code], | |
| title, | |
| duration, | |
| }; | |
| } | |
| return null; // or handle other error cases | |
| }; | |
There was a problem hiding this comment.
Check and apply this change if seems okay. @jagadeeswaran-zipstack
There was a problem hiding this comment.
I don't think this can be used because adding more error codes will make the content condition more complicated. If you think otherwise please let me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
How
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.