Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MainActivity.java to MainActivity.kt #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DeFuex
Copy link
Contributor

@DeFuex DeFuex commented Sep 30, 2020

  • Change java to kotlin
  • Used kotlin standard functions to make code more readable.
  • Added synthetic view injection

@YvesCheung
Copy link
Owner

I appreciate your contribution!!
There is a reason to write the demo in Java, not Kotlin:
See #5 and #9 , which means that Many developers still can't understand Kotlin and expect a Java version.
So I write a Java demo which may help Java users...

@DeFuex
Copy link
Contributor Author

DeFuex commented Oct 10, 2020

Thanks, now i wish i would understand Chinese :) -> #5 #9 ...i understand your point, but is there no value of not adding a secondary Activity showing users how to use your library in Kotlin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants