exec: retrive log files from api_server minio address #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3pointer
commented
Nov 3, 2020
3pointer
commented
- retrive cluster log from api_server minio address
- fix addv bug
YuJuncen
reviewed
Nov 3, 2020
ctl/lib/get_file.py
Outdated
| @@ -31,18 +32,34 @@ def __init__(self, config: Config): | |||
| access_key=config.s3_access_key, | |||
| secret_key=config.s3_secret_key, | |||
| secure=False) | |||
|
|
|||
| def get_artifacts_dir_of(self, cluster_id: int) -> Object: | |||
| self._api_server_client = Minio(api_server_minio, secure=False) | |||
There was a problem hiding this comment.
Seems access_key and secret_key are forgotten here.
BTW, I will prefer to extract them to another config entry (like artifacts_s3_endpoint, etc..), and fully ignore this config s3_endpoint here.
There was a problem hiding this comment.
It seems this minio address is fixed, and doesn't need access_key.
YuJuncen
reviewed
Nov 3, 2020
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.