Resolving early termination due to protocol URL in widget_script.phtml

[damjess]

The protocol-relative URL was causing this script to terminate early on "compilation." The result in the static deployed files (causing an HTTP Error 500) appeared as:

<script type="text/javascript">
(function e(){var e=document.createElement("script");e.type="text/javascript",e.async=true,e.src="<?php echo getenv("TEST_ENV_WIDGET") ?: "</script>

This behavior was observed consistently across development, staging, and production environments.

As of December 2014, Paul Irish's blog on protocol-relative URLs says "2014.12.17: Now that SSL is encouraged for everyone and doesn’t have performance concerns, this technique is now an anti-pattern. If the asset you need is available on SSL, then always use the https:// asset."

My observation is that static resources served through Yotpo are already secure and thus should be enforced using https instead of protocol-relative urls. Changing the url specificity to https resolved the issue and is, in any regard, more secure.

[damjess]

It's really sad how so many developers try to help Yotpo out by opening pull requests and you largely ignore them all while wreaking havoc on our sites. Your development practices are some of the most abhorrent I have seen to date. I will strongly advise my client to reconsider using your platform. I'm sick of the site-breaking bugs and error-log-filling warnings. Get your code together before subjecting paid users to it.

[wabakok-zz]

Hi,

Thanks for writing and I do apologize for the late response.
We're about to release a refactored version of our M2 version shortly which will also include the above.