Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: typescript #107

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

cdaringe
Copy link

problem

  • Flow types are incomplete, out-of-sync, and generally weak, but TS types on reconciler are up-to-date
  • JSX/TSX KV assertions are poor

solution

  • update key deps (react-reconciler, ts, babel, etc)
  • update reconciler to newer API
  • prune a handful of junk examples
  • drop debounced render--let optimized fiber deal w/ it (unless there are shell contraints i ought be aware of!)
  • migrate & refactor, aggressively :/

todo

  • type out prop APIs for elements
  • export first class components, so as to avoid bad react.d.ts typings having all of ReactDOM typings conflict with blessed
  • discern what is wrong w/ an aspect on the reconciler. examples/index has issue when entering a demo, hitting esc closes the demo and demo state is not defined when it should be
  • tests. get serious about tests.

BREAKING CHANGE: remove some sugar apis (e.g. blessed-box can now just
be box), change init flow, and more to be increasingly TS friendly
│ │␊
│ │␊
│ │␊
└──────────────────────────────────────────────────────────┘`
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ sweet snapshots of serialized terminal state! it's like taking screenshots in the browser :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant