wait for ACF5 to be ready

Yoast · Aug 14, 2017 · 94cddc5 · 94cddc5
1 parent c765227
commit 94cddc5
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/js/src/app.js b/js/src/app.js
@@ -18,9 +18,12 @@ var App = function(){
 App.prototype.bindListeners = function(){
 
     if(helper.acf_version >= 5){
-        this.replaceVars = replaceVars.createReplaceVars(collect);
-        acf.add_action('change remove append sortstop', this.maybeRefresh);
-        acf.add_action('change remove append sortstop', replaceVars.updateReplaceVars.bind(this, collect, this.replaceVars));
+        var _self = this;
+        acf.add_action('ready', function () {
+            _self.replaceVars = replaceVars.createReplaceVars(collect);
+            acf.add_action('change remove append sortstop', _self.maybeRefresh);
+            acf.add_action('change remove append sortstop', replaceVars.updateReplaceVars.bind(_self, collect, _self.replaceVars));
+        });
     }else{
         var fieldSelectors = config.fieldSelectors.slice(0);
 

diff --git a/js/yoast-acf-analysis.js b/js/yoast-acf-analysis.js
@@ -19,9 +19,12 @@ var App = function(){
 App.prototype.bindListeners = function(){
 
     if(helper.acf_version >= 5){
-        this.replaceVars = replaceVars.createReplaceVars(collect);
-        acf.add_action('change remove append sortstop', this.maybeRefresh);
-        acf.add_action('change remove append sortstop', replaceVars.updateReplaceVars.bind(this, collect, this.replaceVars));
+        var _self = this;
+        acf.add_action('ready', function () {
+            _self.replaceVars = replaceVars.createReplaceVars(collect);
+            acf.add_action('change remove append sortstop', _self.maybeRefresh);
+            acf.add_action('change remove append sortstop', replaceVars.updateReplaceVars.bind(_self, collect, _self.replaceVars));
+        });
     }else{
         var fieldSelectors = config.fieldSelectors.slice(0);