Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

224 create an element badge to show a counter on top of the ai toast modal #21449

Conversation

vraja-pro
Copy link
Contributor

@vraja-pro vraja-pro commented Jun 21, 2024

Context

  • We want to make the sparkling icon more reusable to be used in the premium.

Summary

This PR can be summarized in the following changelog entry:

  • [@yoast/components 0.0.1 ]Refactors the sparkling icon component for reusability.

Relevant technical choices:

  • I moved the gradient id to the sparkle component because it should always be in that scope.
  • Added className prop for more flexibility. Would be used in the ai counter in premium.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Check the fix ai assessments buttons are working as expected.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Create an element (Badge?) to show a counter on top of the AI Toast / Modal

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jun 21, 2024
@vraja-pro vraja-pro requested a review from a team as a code owner June 21, 2024 15:25
Copy link

github-actions bot commented Jun 21, 2024

@mhkuu Please be aware that following packages have been abandoned and are not actively maintained anymore:

Package name Path
@yoast/babel-preset packages/babel-preset
@yoast/components packages/components
@yoast/e2e-tests packages/e2e-tests
@yoast/helpers packages/helpers
@yoast/jest-preset packages/jest-preset
@yoast/style-guide packages/style-guide

Please consider using the other packages instead.

@vraja-pro vraja-pro changed the base branch from trunk to feature/fix-assessments June 21, 2024 15:27
@mhkuu mhkuu added this to the feature/fix-assessments milestone Jun 24, 2024
vraja-pro and others added 3 commits June 25, 2024 12:31
…ge-to-show-a-counter-on-top-of-the-ai-toast--modal
…seo into 224-create-an-element-badge-to-show-a-counter-on-top-of-the-ai-toast--modal
@coveralls
Copy link

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build afd819a049a542d72e22388849bbcac4594c0f3f

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 48.645%

Totals Coverage Status
Change from base Build 99e6fac60cefcc8dd3c7c78b74297b30f6d30dcb: 0.001%
Covered Lines: 25112
Relevant Lines: 53477

💛 - Coveralls

@Jordi-PV
Copy link
Contributor

@vraja-pro Great job, I'll merge it! 👌 I agree that the gradient id should be within the scope of the component itself, I do not know why it was in the parent component 😓

@Jordi-PV Jordi-PV merged commit 2197c66 into feature/fix-assessments Jun 28, 2024
18 checks passed
@Jordi-PV Jordi-PV deleted the 224-create-an-element-badge-to-show-a-counter-on-top-of-the-ai-toast--modal branch June 28, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants