Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: consistency in terminology #325

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Oct 4, 2023

Context

  • Improve consistency in terminology used.

Summary

This PR can be summarized in the following changelog entry:

  • Improve consistency in terminology used.

Relevant technical choices:

Related to/follow up on #313

The "integration" tests are being renamed to "WP (unit) tests".

This commit updates the references to these tests in the Composer scripts and the GH Actions workflows to follow the new terminology.

Note: the "old" integration-test and integration-coverage Composer scripts will still be available for the time being to facilitate the switch over and give the teams a little time to get used to the new script names.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Check if the GH actions builds run correctly
  • Check if code coverage is correctly uploaded and recorded.
  • Locally check the new scripts (and the old) work correctly.

@jrfnl jrfnl added this to the 4.6 milestone Oct 4, 2023
@jrfnl jrfnl force-pushed the JRF/tests-improve-terminology-consistency branch 2 times, most recently from 03edba0 to e954bc8 Compare October 4, 2023 15:20
@coveralls
Copy link

coveralls commented Oct 4, 2023

Pull Request Test Coverage Report for Build 6408467062

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on JRF/tests-improve-terminology-consistency at 48.608%

Totals Coverage Status
Change from base Build 6408462173: 48.6%
Covered Lines: 1100
Relevant Lines: 2263

💛 - Coveralls

The "integration" tests are being renamed to "WP (unit) tests".

This commit updates the references to these tests in the Composer scripts and the GH Actions workflows to follow the new terminology.

Note: the "old" `integration-test` and `integration-coverage` Composer scripts will still be available for the time being to facilitate the switch over and give the teams a little time to get used to the new script names.
@jrfnl jrfnl force-pushed the JRF/tests-improve-terminology-consistency branch from e954bc8 to 31347ac Compare October 4, 2023 15:53
Copy link
Member

@enricobattocchi enricobattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me!

@jrfnl jrfnl merged commit 455a3dc into trunk Oct 6, 2023
21 checks passed
@jrfnl jrfnl deleted the JRF/tests-improve-terminology-consistency branch October 6, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants