Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull request template #228

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Add pull request template #228

merged 1 commit into from
Jan 7, 2025

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Jan 7, 2025

Mostly as I have a tendency to forget to change the target branch to the oldest supported version for a PR when I haven't worked on this repo for a little while ... oops...

Let's hope this reminder will help prevent such snafus in the future.

Includes a tweak to the Remark config as the file name of the template needs to comply with the requirements by GitHub for such templates and this conflicts with the file name expectations set by Remark (by default).

Ref: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository

@jrfnl jrfnl added this to the 1.1.3 milestone Jan 7, 2025
@coveralls
Copy link

coveralls commented Jan 7, 2025

Coverage Status

coverage: 96.408%. remained the same
when pulling 74f4090 on feature/add-pr-template
into 0bf686b on 1.x.

@jrfnl jrfnl force-pushed the feature/add-pr-template branch from 4438be8 to 8b36f38 Compare January 7, 2025 23:26
@jrfnl jrfnl changed the base branch from 3.x to 1.x January 7, 2025 23:31
Mostly as I have a tendency to forget to change the target branch to the oldest supported version for a PR when I haven't worked on this repo for a little while ... oops...

Let's hope this reminder will help prevent such snafus in the future.

Includes a tweak to the Remark config as the file name of the template needs to comply with the requirements by GitHub for such templates and this conflicts with the file name expectations set by Remark (by default).

Ref: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository
@jrfnl jrfnl force-pushed the feature/add-pr-template branch from 8b36f38 to 74f4090 Compare January 7, 2025 23:31
@jrfnl jrfnl merged commit 034086e into 1.x Jan 7, 2025
169 checks passed
@jrfnl jrfnl deleted the feature/add-pr-template branch January 7, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants