-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: output agg result string when all-field-info
profile
#1452
fix: output agg result string when all-field-info
profile
#1452
Conversation
csv-timeline(-p all-field-info)
|
all-fieldinfo
profile
json-timeline(-p all-field-info)
|
all-fieldinfo
profileall-field-info
profile
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1452 +/- ##
==========================================
- Coverage 81.17% 81.11% -0.07%
==========================================
Files 28 28
Lines 27013 27035 +22
==========================================
+ Hits 21928 21929 +1
- Misses 5085 5106 +21 ☔ View full report in Codecov by Sentry. |
thanks so much! since it is adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fukusuket I checked benchmarks and it was actually a few seconds faster and went from 2.6GB of memory to 2.5GB so LGTM! Thank you!
What Changed
all-field-info
#1450Evidence
Integration-Test
All commands completed successfully.
https://github.com/Yamato-Security/hayabusa/actions/runs/11325635098
CSV timeline and JSON timeline Diff(when rule/config folder exists) ... -p super-verbose
No difference(csv/json) from main branch's results as follows.
https://github.com/Yamato-Security/hayabusa/actions/runs/11325632998
I would appreciate it if you could check it out when you have time🙏