-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Sigma Correlation Event count #1357
Conversation
Correlation(Valid rule)I compared following rule, Correlation ruletitle: Correlation TEST
id: 0e95725d-7320-415d-80f7-004da920fc11
level: informational
correlation:
type: event_count
rules:
- e87bd730-df45-4ae9-85de-6c75369c5d29 # Logon Failure (Wrong Password)
- 8afa97ce-a217-4f7c-aced-3e320a57756d # Logon Failure (User Does Not Exist)
group-by:
- Computer
- SubStatus
timespan: 5m
condition:
gte: 3 ant put following 2 rules in same directory.
Agg ruleauthor: TEST
date: 2024/06/03
modified: 2024/06/03
title: Aggregation TEST
description: Aggregation TEST
id: e87bd730-df45-4ae9-85de-6c75369c5d20
level: informational
status: stable
logsource:
product: windows
service: security
detection:
selection_basic:
Channel: Security
EventID: 4625
selection_error:
SubStatus:
- "0xc000006a" #Wrong password
- "0xc0000064" #Username does not exist error
condition: selection_basic and selection_error | count() by Computer,SubStatus >= 3
timeframe: 5m
falsepositives:
- user mistypes password
tags:
references:
ruletype: Hayabusa Resultthen I confirmed that the result is same.
|
Correlation(Invalid rule)missing title: Many failed logins to the same computer
id: 0e95725d-7320-415d-80f7-004da920fc11
level: informational
correlation:
type: event_count
rules:
- e87bd730-df45-4ae9-85de-6c75369c5d29 # Logon Failure (Wrong Password)
- 8afa97ce-a217-4f7c-aced-3e320a57756d # Logon Failure (User Does Not Exist)
group-by:
- Computer
- SubStatus
timespan: 5m parse error msg appeared in console.
and output error log.
|
hayabusa-sample-evtxI confirmed that there are no differences in the result files as follows csv-timeline
json-timeline
Integration-Testhttps://github.com/Yamato-Security/hayabusa/actions/runs/9343097325 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fukusuket LGTM! Thanks so much!
What Changed
Limitations of current implementation
The following points are not supported because they require more time to implement.
I will consider addressing them as separate PR depending on priority.
Condition
(e.g. 100 > count > 1)I would appreciate it if you could check it out when you have time🙏