Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modify unsupported modifiers #743

Merged
merged 4 commits into from
Oct 13, 2024
Merged

fix: modify unsupported modifiers #743

merged 4 commits into from
Oct 13, 2024

Conversation

fukusuket
Copy link
Collaborator

What Changed

I would appreciate it if you could check it out when you have time🙏

@fukusuket fukusuket added the bug Something isn't working label Oct 13, 2024
@fukusuket fukusuket self-assigned this Oct 13, 2024
@fukusuket fukusuket marked this pull request as ready for review October 13, 2024 01:00
@fukusuket
Copy link
Collaborator Author

I confirmed that markdown is generated after executing the following command.

fukusuke@fukusukenoMacBook-Air supported_modifiers_check % poetry run python supported-modifier.py ../../../sigma ../../../hayabusa-rules ../../doc/SupportedSigmaFieldModifiers.md
2024-10-13 09:54:34,643 - INFO - Starting script execution: supported-modifier.py
2024-10-13 09:54:34,643 - INFO - Starting to process YAML files in directory: ../../../sigma
2024-10-13 09:54:43,316 - INFO - Finished processing YAML files
2024-10-13 09:54:43,317 - INFO - Starting to process YAML files in directory: ../../../hayabusa-rules
2024-10-13 09:54:56,574 - INFO - Finished processing YAML files
2024-10-13 09:54:56,580 - INFO - Markdown report generated and saved to ../../doc/SupportedSigmaFieldModifiers.md
2024-10-13 09:54:56,580 - INFO - Script execution completed in 21.94 seconds
fukusuke@fukusukenoMacBook-Air supported_modifiers_check %

YamatoSecurity
YamatoSecurity approved these changes Oct 13, 2024
View reviewed changes
Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fukusuket LGTM! Thanks so much for the super quick fix!

@YamatoSecurity YamatoSecurity merged commit c8961a4 into main Oct 13, 2024
2 checks passed
@YamatoSecurity YamatoSecurity deleted the 742-update-supported-modifier-table branch October 13, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YamatoSecurity YamatoSecurity YamatoSecurity approved these changes

Assignees

@fukusuket fukusuket

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update supported modifiers table
2 participants
@fukusuket @YamatoSecurity