Workaround winit modifiers issue #249
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The bug is in smithay and should be fixed there. In particular, no one will ever guarantee to send release events, especially given that it's wayland and you're not aware of things like that. |
|
@kchibisov what do you think? |
|
@YaLTeR see above. |
|
I too think it's better to fix in Smithay. I haven't looked deep into the winit backend code there, maybe the fix should be similarly not that difficult? It should also fix some issues with this workaround, like until you press the stuck modifier again it will get added to keys, and also it will send an extra release if you press the same modifier on two keyboards on TTY. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue described in the code comment. It is not a "permanent" fix, but it works just fine for me. The underlying issue is either in xkbcommon, smithay, or the niri compositor (i.e. not the winit backend, but the "main" one running in tty) depending on who exactly you want to blame (xkbcommon for entering a weird irreversible state, smithay for not handling this properly, or niri for not sending the correct events to its client).