Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XLS-60d: DefaultAutoBridge #4923

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

tequdev
Copy link

@tequdev tequdev commented Feb 20, 2024

High Level Overview of Change

Changes the internal default path to include the path of the XRP bridge if sfPaths is unspecified in the Payment transaction.

Context of Change

XRPLF/XRPL-Standards#175

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)

Before / After

If relevant, use this section for an English description of the change at a technical level.
If no path is specified, the impact of the transaction on the node is increased, but if a path is set to mediate XRP, the impact on the node is unaffected.

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 76.98%. Comparing base (c88166e) to head (7e4a770).

Files Patch % Lines
src/test/app/Flow_test.cpp 95.83% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4923      +/-   ##
===========================================
+ Coverage    76.97%   76.98%   +0.01%     
===========================================
  Files         1129     1129              
  Lines       131914   132045     +131     
  Branches     39629    39726      +97     
===========================================
+ Hits        101539   101659     +120     
- Misses       24459    24519      +60     
+ Partials      5916     5867      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tequdev tequdev marked this pull request as ready for review April 16, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants