Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #4904

Merged
merged 5 commits into from May 13, 2024
Merged

Update CONTRIBUTING.md #4904

merged 5 commits into from May 13, 2024

Conversation

dangell7
Copy link
Collaborator

High Level Overview of Change

Update the list of Maintainers and Code Reviewers

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.0%. Comparing base (f4da2e3) to head (d959c84).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #4904   +/-   ##
=======================================
  Coverage     71.0%   71.0%           
=======================================
  Files          796     796           
  Lines        66793   66793           
  Branches     10987   10987           
=======================================
  Hits         47420   47420           
  Misses       19373   19373           

see 3 files with indirect coverage changes

Impacted file tree graph

Copy link
Collaborator

@Silkjaer Silkjaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@intelliot intelliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What order are the reviewers listed in?

If there's no particular order, I think alphabetical may make sense, just so that it's not a ranking and it's not unordered.


## Current Code Reviewers

Code Reviewers are developers who have the ability to review and approve source code changes.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Code Reviewers are developers who have the ability to review and approve source code changes.
Anyone can review code changes, and all reviews are welcome. Code reviews from the following users are generally counted toward the "two" approvals that a pull request typically needs before it is merged.

@shortthefomo shortthefomo mentioned this pull request Feb 26, 2024
9 tasks
@seelabs seelabs merged commit 244ac5e into XRPLF:develop May 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants