fix: more updates for XLS-70 #250
Open
+27
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
It'd be good if this PR could fix what I'm pointing out here |
oleks-rip
reviewed
Dec 2, 2024
|
|
||
| #### 2.1.2. `Flags` | ||
| | Flag Name | Flag Value | | ||
| |-----------|------------| | ||
| |`lsfAccepted`|`0x00010000`| | ||
|
|
||
| The `lsfAccepted` flag represents whether the subject of the credential has accepted the credential. If this flag is disabled, the issuer is responsible for this ledger entry's reserve; if the flag is enabled, the subject of the credential is responsible for the reserve instead. This flag is disabled by default, but is enabled as the result of a successful `CredentialAccept` transaction, or if the secondary signing flow is used to create the credential. | ||
| The `lsfAccepted` flag represents whether the subject of the credential has accepted the credential. If this flag is disabled, the issuer is responsible for this ledger entry's reserve; if the flag is enabled, the subject of the credential is responsible for the reserve instead. This flag is disabled by default, but is enabled as the result of a successful `CredentialAccept` transaction. |
There was a problem hiding this comment.
disabled/enabled sounds inconvenient for flags. Generally flags are set/clear
There was a problem hiding this comment.
@mDuo13 what's the norm for docs?
oleks-rip
reviewed
Dec 2, 2024
| @@ -341,6 +340,7 @@ _Note: the transaction will succeed if (non-expired) credentials are included, b | |||
|
|
|||
| * If a credential isn't valid, the transaction fails. | |||
| * If a credential is expired, the credential is deleted. | |||
| * If the transaction is pre-authorized (either via account or via credential), the transaction will succeed. | |||
|
|
|||
| ## 9. RPC: `deposit_authorized` | |||
There was a problem hiding this comment.
Please add
ledger_entrychanges (additional fieldauthorized_credentialsindeposit_preauthparameter)account_objects/ledger_datachanges (addedcredentialas one of the values fortypeparameter)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title says most of it, also some renames to fix numbers + remove the
ddraft indicator for specs that are soon to be up for voting.