XLS-0065d Single Asset Vault #239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tokeiito
approved these changes
Oct 18, 2024
thejohnfreeman
suggested changes
Oct 22, 2024
thejohnfreeman
approved these changes
Oct 22, 2024
thejohnfreeman
suggested changes
Oct 25, 2024
…Withdraw transaction
thejohnfreeman
suggested changes
Nov 12, 2024
tequdev
reviewed
Dec 5, 2024
| - **Vault**: A ledger entry for aggregating liquidity and providing this liquidity to one or more accessors. | ||
| - **Asset**: The currency of a vault. It is either XRP, a [Fungible Token](https://xrpl.org/docs/concepts/tokens/fungible-tokens/) or a [Multi-Purpose Token](https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0033d-multi-purpose-tokens). | ||
| - **Share**: Shares represent the depositors' portion of the vault's assets. Shares are a [Multi-Purpose Token](https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0033d-multi-purpose-tokens) created by the _pseudo-account_ of the vault. | ||
| **Protocol Instance**: A separate XRP Ledger protocol requiring access to aggregated liquidity. |
There was a problem hiding this comment.
Suggested change
| **Protocol Instance**: A separate XRP Ledger protocol requiring access to aggregated liquidity. | |
| - **Protocol Instance**: A separate XRP Ledger protocol requiring access to aggregated liquidity. |
"Protocol Instance" is only mentioned here in this document. Is this one line necessary?
| "OwnerNode": 2, | ||
| "Owner": "rEXAMPLE9AbCdEfGhIjKlMnOpQrStUvWxYz", | ||
| "Account": "rPseudoAcc1234567890abcdef1234567890abcdef", | ||
| "Data": "This is arbitrary metadata about the vault.", |
There was a problem hiding this comment.
Wouldn't this be returned as a HEX string?
| "Issuer": "rShareIssuer1234567890abcdef1234567890abcdef" | ||
| }, | ||
| "SharesTotal": 5000, | ||
| "WithdrawalPolicy": "FIFO", |
There was a problem hiding this comment.
At the top it says strFirstComeFirstServe, does it return the shortened word here?
Or it could simply return a number.
Co-authored-by: tequ <[email protected]>
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion thread can be found here: #192
Development branch can be found here: rippled/vault