Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 404 page #40

Closed
wants to merge 1 commit into from
Closed

Add 404 page #40

wants to merge 1 commit into from

Conversation

renintw
Copy link
Contributor

@renintw renintw commented Nov 10, 2022 •
edited
Loading

Fixes #15
Related WordPress/wporg-parent-2021#54

Screenshots

Desktop Tablet Mobile
Screen Shot 2022-11-18 at 12 34 18 AM Screen Shot 2022-11-18 at 12 39 21 AM Screen Shot 2022-11-18 at 12 39 10 AM

@renintw renintw self-assigned this Nov 10, 2022
@renintw renintw assigned adamwoodnz and unassigned adamwoodnz Nov 10, 2022
@renintw renintw linked an issue Nov 10, 2022 that may be closed by this pull request
Layout: 404 Page #15
Closed
@StevenDufresne
Copy link
Collaborator

Thanks for the PR!

Ultimately, I do think this should probably be in the parent. I'm curious as to what others think.

The search input doesn't look great.

I think @ryelle or @iandunn can give you a more accurate review of the styles and what is necessary since they were around for the implementation.

@StevenDufresne
Copy link
Collaborator

I just saw this issue in the parent theme.

Link: WordPress/wporg-parent-2021#49

@renintw renintw changed the base branch from fix/archive-templates to main November 16, 2022 16:37
@renintw renintw force-pushed the add/404-page branch 3 times, most recently from 972ecb7 to 04f316d Compare November 17, 2022 12:00
@renintw renintw mentioned this pull request Nov 17, 2022
Merged
@renintw
Copy link
Contributor Author

renintw commented Nov 17, 2022 •
edited
Loading

@StevenDufresne
The implementation has been moved to WordPress/wporg-parent-2021#54, and the search input style has been updated, it follows the styles of showcase search bars. Also, localization has been handled and the screenshots have been updated.

@StevenDufresne
Copy link
Collaborator

@renintw Can we close this and just track this in the parent?

@renintw
Copy link
Contributor Author

renintw commented Nov 22, 2022

Closed in favor of WordPress/wporg-parent-2021#54

@renintw renintw closed this Nov 22, 2022
@renintw renintw deleted the add/404-page branch November 22, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StevenDufresne StevenDufresne StevenDufresne left review comments

@ryelle ryelle Awaiting requested review from ryelle

@adamwoodnz adamwoodnz Awaiting requested review from adamwoodnz

Assignees

@renintw renintw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Layout: 404 Page
3 participants
@renintw @StevenDufresne @adamwoodnz